Closed
Conversation
huang0h
force-pushed
the
ah/pr-review-demo
branch
from
15e7f77 to
9c41650
Compare
huang0h
force-pushed
the
ah/pr-review-demo
branch
from
9c41650 to
2310a4f
Compare
huang0h
commented
Jan 26, 2025
Contributor
Author
huang0h
left a comment
huang0h
left a comment
There was a problem hiding this comment.
looks good, a few questions to clarify here:
| email: string; | ||
| year: string; | ||
| major: string; | ||
| // TODO: ask if we still want to do user-submitted questions |
Contributor
Author
There was a problem hiding this comment.
❓ Did we ever ask about this? If so, was this implemented or not?
| email: string; | ||
| year: string; | ||
| major: string; | ||
| // TODO: ask if we still want to do user-submitted questions |
Contributor
Author
There was a problem hiding this comment.
❓ Did we ever ask about this? If so, was this implemented or not?
| return ( | ||
| <div> | ||
| <Container maxWidth="md"> | ||
| <Helmet> |
Contributor
Author
There was a problem hiding this comment.
❓ What does <Helmet> do? why do we use this
Comment on lines
+56
to
+80
| <TextField | ||
| label="First Name" | ||
| value={data.firstName} | ||
| onChange={(event) => setData({...data, firstName: event.target.value})} | ||
| /> | ||
| <TextField | ||
| label="Last Name" | ||
| value={data.lastName} | ||
| onChange={(event) => setData({...data, lastName: event.target.value})} | ||
| /> | ||
| <TextField | ||
| label="Email" | ||
| value={data.email} | ||
| onChange={(event) => setData({...data, email: event.target.value})} | ||
| /> | ||
| <TextField | ||
| label="Graduation Year" | ||
| value={data.year} | ||
| onChange={(event) => setData({...data, year: event.target.value})} | ||
| /> | ||
| <TextField | ||
| label="Major" | ||
| value={data.major} | ||
| onChange={(event) => setData({...data, major: event.target.value})} | ||
| /> |
Contributor
Author
There was a problem hiding this comment.
⛏️ It looks like there's a lot being repeated here - could we possibly abstract this out into something?
| /> | ||
| </RadioGroup> | ||
| <StyledButton onClick={(event) => { | ||
| console.log('submitting form', data); |
Contributor
Author
There was a problem hiding this comment.
This is a pretty big function - could we possibly break it up into a few smaller functions?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR review emoji guide: https://github.com/erikthedeveloper/code-review-emoji-guide
ℹ️ Issue
Closes #999
📝 Description
Briefly list the changes made to the code:
✔️ Verification
Contact page:
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!